VisualEditor: Still get a pawn when select-all->replace in Firefox
Closed, ResolvedPublic

Description

Go to demos/ve/?page=aliens in Firefox; select all:

TypeError: end is undefined    ve.ce.Surface.js (line 980)

Press "a" (or backspace and then "a"):

TypeError: start is undefined  ve.ce.Surface.js (line 995)

(And a pawn appears in its own <p> above the a.)

On any click thereafter,

TypeError: node is null        ve.ce.Surface.js (line 1073)

Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57355

Jdforrester-WMF created this task.Via LegacyNov 24 2012, 2:46 AM
TrevorParscal added a comment.Via ConduitNov 26 2012, 11:05 PM

I resolved this in Ia7347527e6466262e819f456404b32926fd95e34 by correcting the offsets before showing selection. This seems to work well so far, but really getNodeAndOffset is a nasty function that needs some love soon.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.