Page MenuHomePhabricator

Inclusion of special pages with parameters
Closed, ResolvedPublic

Description

Author: gangleri

Description:
Hallo!

http://test.leuksman.com/index.php/Project:Special_pages/inclusions#tests
and
http://test.leuksman.com/index.php/Project:Categories/inclusions#tests

are showing some inclusion test of pages in namespace category and special.

The parameters used in the URL's should be used accordingly. Parameter
conversion from special characters to {{PAGENAMEE}} style values should be done
automaticaly providing same results.

Regards Reinhardt [[user:gangleri]]


Version: 1.5.x
Severity: enhancement
URL: http://test.leuksman.com/index.php/Project:Special_pages/inclusions#tests

Details

Reference
bz2447

Related Objects

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 8:31 PM
bzimport set Reference to bz2447.
bzimport added a subscriber: Unknown Object (MLST).

gangleri wrote:

not about inclusion of special pages, categories:
I thing it id fair enough not to list pages included trough special pages in
"Special:Whatlinkshere", "Special:Recentchangeslinked".

gangleri wrote:

*** Bug 4365 has been marked as a duplicate of this bug. ***

gangleri wrote:

*note*
bug 4365: Make Special:Contributions/Newbies includable
is not a duplicate only a subset of bug 2447

jesus wrote:

patch against double-include-problem

may this patch against the svn works

Attached:

jesus wrote:

Comment on attachment 1849
patch against double-include-problem

Index: includes/Parser.php

  • includes/Parser.php (revision 14494)

+++ includes/Parser.php (working copy)
@@ -2771,6 +2771,7 @@

			} else {
				# set $text to cached message.
				$text = $linestart .

$this->mTemplates[$piece['title']];
+ $noparse =
$this->mTemplatesParsed[$piece['title']];

			}
		}

@@ -2835,6 +2836,7 @@

  1. modifiers such as RAW: produce separate cache

entries

				if( $found ) {
					$this->mTemplates[$piece['title']] =

$text;
+
$this->mTemplatesParsed[$piece['title']] = $noparse;

					$text = $linestart . $text;
				}
			}

Index: includes/SpecialPage.php

  • includes/SpecialPage.php (revision 14494)

+++ includes/SpecialPage.php (working copy)
@@ -311,7 +311,9 @@

			$profName = 'Special:' . $page->getName();
			wfProfileIn( $profName );

+ $saveit = $this->mStripState;

			$page->execute( $par );

+ $this->mStripState = $saveit;

			wfProfileOut( $profName );
			$retVal = true;
		}

gangleri wrote:

note: the original url is not valid any more.

If this bug is fix it would be very helpful to know the correct syntax.

How {{special:Listusers|uselang=en&limit=1&username={{BASEPAGENAMEE}}}} can be included?

Please see some tests at

http://test.wikipedia.org/wiki/User:Gangleri/bugzilla_002447

Thanks for every help! Kind regards [[user:gangleri]]

gangleri wrote:

reopened this bug because of missing replay at comment #6

Regards Reinhardt [[user:gangleri]]

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

sumanah wrote:

jesus c. meyendriesch, thanks for your patch and sorry for the wait. I'm adding the "need-review" keyword here to indicate that your patch is still awaiting review.

Thanks.

reachouttothetruth wrote:

This should be fixed in r93758. Special:ListUsers is not a includable special page, but special pages that are includable will accept parameters with the same syntax you would use for templates. If there are issues that haven't been addressed yet, please re-open.

*** This bug has been marked as a duplicate of bug 15558 ***