Page MenuHomePhabricator

Remove the label/description uniqueness constraint for items
Closed, DeclinedPublic


The constraint that only one item can have a given combination of label and description per language is nice to have, but hard to enforce: the consistency requirements need transactional logic, which causes excessive lock retention and time outs. So, just drop it.

Note that we still need to keep the "unique label per language" constraint on properties (and probably also on queries). Maybe we need a dedicated DB table for these.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:45 AM
bzimport set Reference to bz42685.
bzimport added a subscriber: Unknown Object (MLST).

The requirement here is not to remove the check for conflicting items upon save: we can keep that check, as and advisory. But we can't *guarantee* uniqueness of label/description/language efficiently, and we shouldn't try. So, updates of the wb_term table should be reviewed to minimize lock retention.

Change I4e3bf661: (bug 42685) item label/description is not unique.