Page MenuHomePhabricator
Create Task
Maniphest T45679

mb_check_encoding() change in php 5.4.10
Closed, ResolvedPublic
Actions

Description

testIsUtf8WithMbstring is failing in PHP 5.4.10 with the strings:

  • "\xf8\x88\x80\x80\x80" (#6)
  • "\xfc\x84\x80\x80\x80\x80" (#7)
  • "\xf7\xbf\xbf\xbf" (#11)
  • "\xfb\xbf\xbf\xbf\xbf" (#12)
  • "\xf4\x90\x80\x80" (#18)

mb_check_encoding( $string, 'UTF-8' ) is returning false in php 5.4.10 (they made their checks stricter?)

Hashar, I'm assigning this to you as 750db30d9 author.

Version: 1.21.x
Severity: normal

Details

Reference
bz43679

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:23 AM
• bzimport added projects: MW-1.22.0-release, MediaWiki-General, [DO NOT USE] NewPHP.
• bzimport set Reference to bz43679.
Platonides created this task.Jan 6 2013, 1:47 PM
hashar added a comment.Jan 7 2013, 7:03 PM

Did it succeed with a previous 5.4 release or did it start failing with 5.4.10 ?

hashar added a comment.Jan 22 2013, 7:45 AM

I do not yet have time to look at this for now, I guess we want our test to react differently whenever PHP is 5.4 or later.

JanZerebecki added a comment.Apr 5 2013, 1:47 PM

This happens for me on PHP 5.4.4-14 (Debian).
Most likely this item from the PHP 5.4.0 NEWS file indicates the change: Ill-formed UTF-8 check for security enhancements. (Rui)

gerritbot added a comment.May 24 2013, 3:32 PM

Related URL: https://gerrit.wikimedia.org/r/65300 (Gerrit Change I026eff69236187ce3d2ff2fc261a5e1d9cd88b24)

JanZerebecki added a comment.May 25 2013, 9:59 AM

Found https://gerrit.wikimedia.org/r/#/c/48743/ which also intends to fix this bug.

Aklapper added a comment.Aug 8 2013, 7:53 AM

Both patches mentioned here have received -1's and likely need rework.

gerritbot added a comment.Sep 16 2013, 4:34 AM

Change 48743 had a related patch set uploaded by PleaseStand:
Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF

https://gerrit.wikimedia.org/r/48743

gerritbot added a comment.Sep 19 2013, 4:12 PM

Change 48743 merged by jenkins-bot:
Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF

https://gerrit.wikimedia.org/r/48743

Danny_B moved this task from Unsorted to PHP 5.4 on the [DO NOT USE] NewPHP board.Jul 11 2016, 1:54 AM
Danny_B removed a parent task: T32092: [DO NOT USE] MediaWiki PHP 5.4 compatibility (tracking) [superseded by #NewPHP].Jul 27 2016, 12:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits