The URLs (return URLs, etc.) that are provided to OpenID consumers and providers end up being invalid when $wgServer is protocol-relative.
Version: master
Severity: normal
Description
Description
Details
Details
- Reference
- bz44293
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T66475 Make crosswiki bits and pieces truly global (tracking) | ||
| Declined | Feature | None | T15631 Wikimedia should become an OpenID provider | ||
| Declined | None | T31254 [SUGGESTION] Expose group memberships for query through OpenID teams extension | |||
| Declined | Wikinaut | T25735 Allow different user grouping for OpenID users | |||
| Declined | None | T61631 Enable Facebook login on Wikimedia wikis | |||
| Declined | None | T11604 Get OpenID extension to a state where it could be used on Wikimedia projects as a provider | |||
| Resolved | Wikinaut | T46293 [BUG] OpenID URLs are invalid when $wgServer is relative |
Event Timeline
Comment Actions
Yes, the attached patch solves all of the problems (it now functions as a consumer and provider successfully).
Comment Actions
Today I'm seeing an OpenID failure on an install that has
$wgServer = "//" . $_SERVER["SERVER_NAME"];
Is that the same as this bug, or related?
Comment Actions
(In reply to comment #5)
Today I'm seeing an OpenID failure on an install that has
$wgServer = "//" . $_SERVER["SERVER_NAME"];
Is that the same as this bug, or related?
Same bug. The issue is that since $wgServer is relative, the extension puts protocol-relative URLs in the <meta> tags for OpenID, which causes errors when these URLs are detected by the OpenID provider.
Comment Actions
Looks like the fix has been languishing in gerrit for months -- what's happening there? Do you just need a reviewer?
Comment Actions
(In reply to comment #6)
(In reply to comment #5)
Today I'm seeing an OpenID failure on an install that has
$wgServer = "//" . $_SERVER["SERVER_NAME"];
Is that the same as this bug, or related?
Same bug. The issue is that since $wgServer is relative, the extension puts
protocol-relative URLs in the <meta> tags for OpenID, which causes errors
when
these URLs are detected by the OpenID provider.
thanks, I was not aware, that this is the reason why openID on my two "instances" was broken.
Will check the fix now.
Comment Actions
For those being interested in the solution:
a fix is now available and it would be really great, if all of you can confirm, that it really solves the problem.
https://gerrit.wikimedia.org/r/#/c/45474/
This version is live on
http://openid-wiki.instance-proxy.wmflabs.org/wiki/Main_Page and http://openid-wiki.instance-proxy.wmflabs.org and http://openid-wiki2.instance-proxy.wmflabs.org
Comment Actions
https://gerrit.wikimedia.org/r/45474 (Gerrit Change I087a6eeeec1ea2206968e0cabb83b62c4275d570) | change APPROVED and MERGED [by Wikinaut]