Page MenuHomePhabricator

VisualEditor: Oddness repetition/wrong diff (from Parsoid?) on save with some funky markup
Closed, ResolvedPublic

Description

empty review pane, should show heading markup for non-Latin string

Using a string like "āæǣ" or special characters like "☺☻♥♦"

Highlight the string in VE
Choose "Heading 1"

VE displays the string larger, as expected

Click "Review and save""

Note that review pane is empty, see screen shot.
Click "Looks good to me" and finish saving.

The non-Latin string has not been affected and the Heading not been applied.

Note that normal ASCII latin strings work fine.
Also note that the regular editor applies the Heading markup to non-latin strings correctly.


Version: unspecified
Severity: normal
URL: https://en.wikipedia.org/w/index.php?title=User:Cmcmahon(WMF)&oldid=535414434

Attached:

Screen_shot_2013-01-28_at_3.28.52_PM.png (345×1 px, 28 KB)

Details

Reference
bz44442

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:18 AM
bzimport set Reference to bz44442.

Afraid I can't reproduce this (it works fine for me with Firefox, Safari and Chrome from here - I get as-expected diffs, which also then save appropriately) - what wiki / version of the software was this on, and with what browser?

Chrome, OSX, enwiki. I can reproduce this reliably on my User page on enwiki.

OK, interesting. This is actually a quite complicated bug, and is not actually correctly-named.

The problem appears to be the '[http://barbarbar bar]' beforehand - if you remove this, the diff magically "works" - BUT it fails to show the '[http://barbarbar bar]' being removed, and indeed puts it after the header too, with another paragraph of 'āæǣ'. The diff is the behaviour that results from the save, even though this isn't a fair representation of the document model (the '[http://barbarbar bar]' is removed from the DM).

RK: this feels like a Parsoid bug (or two?), but might be on our side related to SelSer? - can you confirm before we sling it at them?

This would make a nice automated browser regression test

guanhao7 wrote:

I found it is impossible to use Sogou Input or other Input software to type Chinese with this tool.

You may download a Sogou Input(which is the most popular one in china, on the Windows) to test it.

Here is the download link: http://download.ime.sogou.com/sogou_pinyin_65f.exe?st=lTJ11fWyCsrUkj6oWiGI_Q&e=1359462829&fn=sogou_pinyin_65f.exe

The underlying issue (with Parsoid) has been resolved with the new version of Parsoid finally running on the cluster; marking as FIXED.

[I have forked comment 6 into bug 47436.]