Page MenuHomePhabricator

File: pages for images broken on wmf9 ( by TimedMediaHandler
Closed, ResolvedPublic


PHP fatal error in /usr/local/apache/common-local/php-1.21wmf9/extensions/TimedMediaHandler/TimedMediaHandler.hooks.php line 214:
Call to undefined method PNGHandler::isAudio()

Same on JPEG files, but it's JpegHandler::isAudio doesn't exist.

This probably shouldn't be called on files that don't belong to TimedMediaHandler... or it should be checking the handler class to make sure it's something it understands... or something.

Version: master
Severity: critical



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:33 AM
bzimport set Reference to bz44656.

Also used on 209:

if( ( $mediaType == 'webm' || $mediaType == 'ogg' || $mediaType =='mp4' ) && ! $file->getHandler()->isAudio( $file ) ){

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:21 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:22 AM