Page MenuHomePhabricator

[CODE QUALITY] Refactor the storage of "trust" information in the user properties (use JSON)
Open, LowPublic

Description

Currently, the information of trusted sites is stored in an usual way. Should be changed to serialized or better, simply to JSON, fully.

The relevant parts which needs to be changed are in

+ SpecialOpenIDServer.body.php

  1. Get the user's configured trust value for a particular trust root.
  2. Returns one of three values:
  3. * NULL -> no stored trust preferences
  4. * false -> stored trust preference is not to trust
  5. * array -> possibly empty array of allowed profile fields; trust is OK

function GetUserTrust( $user, $trust_root ) {

function SetUserTrust( &$user, $trust_root, $value ) {

static function GetUserTrustArray( $user ) {

function SetUserTrustArray( &$user, $arr ) {

Blocks T47323: OpenID Preference tab: Show list of "trust" records [SOLVED] ; add links for selective deletion [SOLVED]


Version: master
Severity: enhancement

Details

Reference
bz45914

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:31 AM
bzimport set Reference to bz45914.
Wikinaut created this task.Mar 8 2013, 10:44 PM

blocks deployment

The trust data is already JSON-encoded (encapsulated) stored and respectively retrieved using

+ $user->setOption( 'openid_trust', FormatJSON::encode( $trust_str ) ); )

in SpecialOpenIDServer.body.php.

So this bug is of minor importance - no need to fix this with priority (setting => low importance)

Aklapper removed Wikinaut as the assignee of this task.Jun 18 2015, 2:08 PM
Aklapper added a subscriber: Aklapper.

[Resetting task assignee to avoid cookie-licking. Please reclaim the task when you plan to actively work on this task. Thanks!]