Page MenuHomePhabricator

Diff's and literal compare of numbers fails
Closed, ResolvedPublic

Description

Author: gangleri

Description:
Hallo!

See
http://jadesukka.homelinux.org:8180/betawiki/Image:Diffs_and_numbers_01.jpg
a diff in the preview
http://jadesukka.homelinux.org:8180/betawiki/Image:Diffs_and_numbers_02.jpg
a diff from history

bugzilla:2372
bugzilla:02372

bugzilla:65|65, bugzilla:2130|2130
bugzilla:00065|00065, bugzilla:02130|02130

bugzilla:2718
bugzilla:02718

are *not differentiated.
Note: I removed the wiki brakets because the examples are not at wikipedia:en .

Regards Reinhardt [[user:gangleri]]


Version: 1.5.x
Severity: trivial
URL: http://test.leuksman.com/index.php?title=Template:InterWiki_table&diff=8864&oldid=8842

Details

Reference
bz2824

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:39 PM
bzimport set Reference to bz2824.
bzimport added a subscriber: Unknown Object (MLST).

I can confirm it happens, but DifferenceEngine.php is too terrible for mere mortals to
comprehend.

robchur wrote:

Or, to put it another way, it's a mess.

gangleri wrote:

recovered first screen dump for bug 02824

see bug 349 comment 5
Bug 349: diff didn't highlight a change

After uploading both screen dumps I will mark this bug as dependend of bug
00349 and mark as FIXED.

Attached:

diffs_and_numbers_01.jpg (444×1 px, 104 KB)

gangleri wrote:

recovered second screen dump for bug 02824

Attached:

diffs_and_numbers_02.jpg (491×1 px, 110 KB)

gangleri wrote:

REOPENed
see bug 349 comment 8
bug 349: diff didn't highlight a change

gangleri wrote:

from bug 349 comment 8

http://en.wikipedia.org/w/index.php?title=Lakh&action=edit&oldid=6163130
... 30,000,000.
http://en.wikipedia.org/w/index.php?title=Lakh&action=edit&oldid=6115828
... 30,00,000.
is *not* covered by attachment.cgi id=1190

Here are more numbers separated with "," other countries are using ".". Please
change the code that diff sees three "number strings" . Compare only sequences
of characters between 0 and 9, do not include ",", ".", "e" or "E" as in 10E3.

Please note that only the testcases from
bug 2824: diffs and literal compare of numbers fails
are fixed. I will reopen bug 2824 because "30,000,000" is a valid number.

http://en.wikipedia.org/w/wiki.phtml?title=Lakh&diff=6163130&oldid=6115828
the original url from bug 349 is FIXED

Will tray to generate the test cases from bug 349 comment 8.

Do not use anything on Wikimedia sites at this time for testing the internal
diff engine, as we're using an external diff engine now (wikidiff2).

Seems to have been fixed some time ago.