Page MenuHomePhabricator

changeTitle() creates redirects even in case of redirid == 0
Closed, ResolvedPublic

Description

Title:moveTo() explicitly sets createRedirect to false (redirid == 0) SMWSQLStore3Writers::changeTitle() never checks the redirid therefore smw_fpt_redi contains gost redirects for pages with (Special:MovePage - > Leave a redirect behind unchecked)

There are two approaches to change this behaviour:

  1. Execute updateRedirects() only when $redirid != 0 which will means that all possible existing associations with a moved page are also gone or
  1. Execute updateRedirects() in all cases (copying associations with the moved page) but in case of $redirid == 0 execute doDataUpdate( $oldtitle ) in order for the oldTitle (which got deleted) to delete the container for the oldTitle object as well.

Note

The hook ArticleDelete is not called for a moved oldTitle therefore deleteSubject() is also not called which means the container for oldTitle still has a references to the newTitle (see smw_fpt_redi).

Example

See [1], [2] where [1] is delete but shows semantic data from [2]. When looking at "Has query" property reveals that Demo:Foo has suddenly elements of Demo:Foo2.

[1] http://www.semantic-mediawiki.org/wiki/Special:Browse/Demo:Foo
[2] http://www.semantic-mediawiki.org/wiki/Special:Browse/Demo:Foo2


Version: unspecified
Severity: normal

Details

Reference
bz46930

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:16 AM
bzimport set Reference to bz46930.
bzimport added a subscriber: Unknown Object (MLST).

Related URL: https://gerrit.wikimedia.org/r/57757 (Gerrit Change Ibad8cd133cc985656346769787698a8519f5e58e)

https://gerrit.wikimedia.org/r/57757 (Gerrit Change Ibad8cd133cc985656346769787698a8519f5e58e) | change APPROVED and MERGED [by jenkins-bot]