Page MenuHomePhabricator

$wgLogTypes contains "suppress" twice on enwiki
Closed, ResolvedPublic

Description

When looking at possible values of the logtype property of the watchlist API module on enwiki [1], the value "suppress" is included twice.

This list comes from the variable $wgLogTypes. The first "suppress" is default, the second seems to be added by ArticleFeedbackv5 [2].

I think $wgLogTypes should not contain duplicate values, so ArticleFeedbackv5 shouldn't be adding it.

[1]: http://en.wikipedia.org/w/api.php?format=xml&action=paraminfo&querymodules=watchlist
[2]: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ArticleFeedbackv5.git;a=blob;f=ArticleFeedbackv5.php;h=79a87377bce0b98eb868c93d5dfc288f2b25d08f;hb=HEAD#l458


Version: master
Severity: minor

Details

Reference
bz47944

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:28 AM
bzimport added a project: ArticleFeedbackv5.
bzimport set Reference to bz47944.
bzimport added a subscriber: Unknown Object (MLST).
Svick created this task.May 1 2013, 5:08 PM
Reedy added a comment.May 1 2013, 5:15 PM

reedy@fenari:~$ mwscript eval.php enwiki

var_dump( $wgLogTypes );

array(29) {

[0]=>
string(0) ""
[1]=>
string(5) "block"
[2]=>
string(7) "protect"
[3]=>
string(6) "rights"
[4]=>
string(6) "delete"
[5]=>
string(6) "upload"
[6]=>
string(4) "move"
[7]=>
string(6) "import"
[8]=>
string(6) "patrol"
[9]=>
string(5) "merge"
[10]=>
string(8) "suppress"
[11]=>
string(6) "review"
[12]=>
string(6) "stable"
[13]=>
string(8) "gblblock"
[14]=>
string(10) "renameuser"
[15]=>
string(10) "globalauth"
[16]=>
string(9) "gblrights"
[17]=>
string(11) "abusefilter"
[18]=>
string(17) "articlefeedbackv5"
[19]=>
string(8) "suppress"
[20]=>
string(19) "pagetriage-curation"
[21]=>
string(19) "pagetriage-deletion"
[22]=>
string(11) "institution"
[23]=>
string(6) "course"
[24]=>
string(7) "student"
[25]=>
string(6) "online"
[26]=>
string(6) "campus"
[27]=>
string(10) "instructor"
[28]=>
string(8) "newusers"

}

Related URL: https://gerrit.wikimedia.org/r/61795 (Gerrit Change I850f0f179b2b681ed50655b5b1b545fb311ee25e)

Related URL: https://gerrit.wikimedia.org/r/61798 (Gerrit Change I956b69762ad5888f26fb3202d372f34cdb7ed7ef)