Page MenuHomePhabricator

$wgLogTypes contains "suppress" twice on enwiki
Closed, ResolvedPublic


When looking at possible values of the logtype property of the watchlist API module on enwiki [1], the value "suppress" is included twice.

This list comes from the variable $wgLogTypes. The first "suppress" is default, the second seems to be added by ArticleFeedbackv5 [2].

I think $wgLogTypes should not contain duplicate values, so ArticleFeedbackv5 shouldn't be adding it.


Version: master
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:28 AM
bzimport set Reference to bz47944.
bzimport added a subscriber: Unknown Object (MLST).

reedy@fenari:~$ mwscript eval.php enwiki

var_dump( $wgLogTypes );

array(29) {

string(0) ""
string(5) "block"
string(7) "protect"
string(6) "rights"
string(6) "delete"
string(6) "upload"
string(4) "move"
string(6) "import"
string(6) "patrol"
string(5) "merge"
string(8) "suppress"
string(6) "review"
string(6) "stable"
string(8) "gblblock"
string(10) "renameuser"
string(10) "globalauth"
string(9) "gblrights"
string(11) "abusefilter"
string(17) "articlefeedbackv5"
string(8) "suppress"
string(19) "pagetriage-curation"
string(19) "pagetriage-deletion"
string(11) "institution"
string(6) "course"
string(7) "student"
string(6) "online"
string(6) "campus"
string(10) "instructor"
string(8) "newusers"


Related URL: (Gerrit Change I850f0f179b2b681ed50655b5b1b545fb311ee25e)

Related URL: (Gerrit Change I956b69762ad5888f26fb3202d372f34cdb7ed7ef)