Page MenuHomePhabricator

Change the default value for the concurrent uploads limit to be named "default"
Closed, InvalidPublic

Description

A recent patch introduced a weird usability issue in UploadWizard where the 0th element in the array of valid options is 'default'. We should probably either

A) Use 0 for both the index and the value, and explain that 0 means "default" in an i18n-able message or

B) Use 'default' for both the index and the value and get cursed at by the i18n people.

If there are other options I'm open to them, but getting 0 out of that array would be desirable.


Version: master
Severity: enhancement

Details

Reference
bz48280

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:22 AM
bzimport set Reference to bz48280.
bzimport added a subscriber: Unknown Object (MLST).

@mark, can you be more specific, because I know this code quite well, and with the above description I still don't know how to pinpoint the piece of code you are discussing :D

mtraceur: Could you answer comment 1, please?

Sorry about the slow response, guys!

I honestly don't even know what I was talking about, I'll close this for now.