Page MenuHomePhabricator

mw.hook listeners for GuidedTour for shouldSkip
Closed, ResolvedPublic

Description

Investigate how mw.hook could be useful for GuidedTour. One idea is subscribing to state changes for shouldSkip. For instance, UploadWizard has an AJAX-type interface where you go from step to step without changing pages.

If we could listen to those steps, we could trigger the shouldSkip check (by calling guiders.resume or maybe another method that only checks this).


Version: master
Severity: enhancement

Details

Reference
bz48507

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz48507.

I'm working on a change set right now that uses mw.hook for VE like this.

This is done for VisualEditor. I made this a tracking bug, and opened a separate one (bug 51985) for UploadWizard.

Change 116228 had a related patch set uploaded by Mattflaschen:
WIP: Refactor and add non-linear tours, with tests

https://gerrit.wikimedia.org/r/116228

Change 116228 merged by jenkins-bot:
Refactor and add non-linear tours, with tests

https://gerrit.wikimedia.org/r/116228

Danny_B set Security to None.