Page MenuHomePhabricator

Icon-only-buttons broken in vector
Closed, ResolvedPublic

Description

Original Bug title:
Icon-only-buttons broken in vector

broken by https://bits.wikimedia.org/static-1.22wmf4/resources/jquery.ui/themes/vector/jquery.ui.button.css
body .ui-button {
/*...*/

width: auto

/*...*/
}

which overwrites

button.ui-button-icon-only {

width: 2.4em

}

Test case (can be executed in a JS console):

$button = $('<button>').text('required but not visible').button({
icons: {
primary: "ui-icon-locked"
},
text: false
});
mw.util.$content.prepend($button);


Version: 1.22.0
Severity: minor

Details

Reference
bz48593

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:44 AM
bzimport added a project: MediaWiki-Interface.
bzimport set Reference to bz48593.
Rillke created this task.May 17 2013, 10:30 PM

Created attachment 12335
rendering of broken vector button

Attached:

Created attachment 12336
expected result

Attached:

Created attachment 12337
new proposed content of resources/jquery.ui/themes/vector/jquery.ui.button.css

Attached:

Created attachment 12338
Patch to apply against resources/jquery.ui/themes/vector/jquery.ui.button.css

Attached:

Thanks! Anybody is welcome to use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this patch as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

so the patch can get reviewed and merged into the codebase.

Obviously no one wanted. Isn't there a way to submit a patch to gerrit quickly? A web-interface like github has, perhaps?

(In reply to comment #6)

Obviously no one wanted. Isn't there a way to submit a patch to gerrit
quickly? A web-interface like github has, perhaps?

No, but it may or may not be in the works. (Currently you can already edit commit messages from the web interface using the little pencil icon on its top-right corner.)

Change 74345 had a related patch set uploaded by Matmarex:
Fixing width of icon-only-buttons in Vector skin

https://gerrit.wikimedia.org/r/74345

Change 74345 merged by jenkins-bot:
Fixing width of icon-only-buttons in Vector skin

https://gerrit.wikimedia.org/r/74345