Page MenuHomePhabricator

When user is deleted, some tables are not cleaned
Closed, ResolvedPublic

Description

In UserMerge::deleteUser, the user_former_groups and user_properties table are not cleaned along with the user_groups and user table. NOTE: These tables didn't exist until recently (but by recently, I mean like MW 1.16 or something). The current extension page says this extension supports down to MW 1.13, so fixing this bug will break that compatibility. However, considering anything under MW 1.18 is deprecated and completely passed its lifecycle, I think it's safe to move forward here.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49517

Details

Reference
bz49518

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz49518.

Thomas, are you still planning to work on this?

(In reply to Kunal Mehta (Legoktm) from comment #1)

Thomas, are you still planning to work on this?

I am a little bit short in time currently, but if you would be so kind to supply a proper patch, I will review/test it, and commit later.

Change 160846 had a related patch set uploaded by Legoktm:
Update user_former_groups and user_properties, improve user_groups updating

https://gerrit.wikimedia.org/r/160846

Change 160846 merged by jenkins-bot:
Update user_former_groups and user_properties, improve user_groups updating

https://gerrit.wikimedia.org/r/160846