Page MenuHomePhabricator

Null revision on page protection based on old version - no conflict detection or load from slave?
Closed, ResolvedPublic


I am not sure, if this case is similiar to bug 16441, but on [1] the null revision for the protect action is based on the wrong base revision (because protection should have a 0 byte diff).
There is a difference from 1 second between the save before the protect, so this can also be a slave lag.
For the same reason the diff hint on [2] is wrong, because it tells you, that there are 0 users between the two diffs.


Needs testing, if the null revision is loaded from slave.

Version: 1.22.0
Severity: normal


Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:50 AM
bzimport set Reference to bz49581.
bzimport added a subscriber: Unknown Object (MLST).

Revision::newNullRevision uses the master

Change 263932 had a related patch set uploaded (by Aaron Schulz):
Avoid races on null revision insertion

Change 263932 merged by jenkins-bot:
Avoid races on null revision insertion

Umherirrender claimed this task.

Bad to retest, so something was changes and it is hopefully fixed