Page MenuHomePhabricator

VisualEditor: EventLogging gives the same pageViewSessionId for all edits
Closed, ResolvedPublic

Description


Version: unspecified
Severity: normal

Details

Reference
bz49586

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:50 AM
bzimport set Reference to bz49586.

All events in Edit_5563071 appear to have the same value for event_pageViewSessionId (2147483647).

When fixing, we will want to bump the event_version value.

ori added a comment.Jun 14 2013, 5:50 PM

(In reply to comment #1)

All events in Edit_5563071 appear to have the same value for
event_pageViewSessionId (2147483647).

It was simply overflowing its column type (int). I set it to 'bigint' and it's fine now.

It's odd that we haven't run into this before! It's because we ordinarily convert timestamps to byte strings, like the rest of MediaWiki. This is the first time we've tried to save timestamps as integers. The int type is good for values between +/- 2,147,483,647, which has been adequate for all other use cases.

When fixing, we will want to bump the event_version value.

Well, since this did not require a deployment, I instead moved all existing rows in the 'Edit' table to 'z_Edit_5563071'. Any events that go into the current 'Edit_5563071' will be fine.

Related URL: https://gerrit.wikimedia.org/r/68712 (Gerrit Change Iddb9eb9c64b55b25445ddf9e474d312b685978a6)

Merged and we'll get this out on Monday so we can test it.