Page MenuHomePhabricator

DSR on DOM-based template expansions is buggy
Closed, ResolvedPublic

Description

The reason for dirty diffs in infoboxes and other templates being seen currently on en-wp VE edits is because of incorrect DSR on reused template expansions.

Ex:

  1. dsr":[2076,2080,2,2] for the infobox on en:Libreoffice
  2. dsr":[878,882,2,2] for the infobox on en:Bleak House

This then marks the infobox dirty during serialization (although not sure why it should if the same cached html (with buggy dsr) is used by the serializer -- so, maybe something is off there as well) which causes it to be serialized via the regular serializer -- which then normalizes whitespace, etc.

NOTE: Ignoring data-parsoid attribute during dom-diff would cause more problems since the incorrect DSR values would be used to return original wikitext which would have broken serialize WT more seriously.

Related: we need a way of testing this functionality as well.


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49608

Details

Reference
bz49655

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:55 AM
bzimport added a project: Parsoid-DOM.
bzimport set Reference to bz49655.
ssastry created this task.Jun 16 2013, 9:22 PM

Related URL: https://gerrit.wikimedia.org/r/69119 (Gerrit Change I0fb2419e6e303e715e85e5c0d91d8cefd63e5c42)

https://gerrit.wikimedia.org/r/69119 (Gerrit Change I0fb2419e6e303e715e85e5c0d91d8cefd63e5c42) | change APPROVED and MERGED [by jenkins-bot]

Related patch: https://gerrit.wikimedia.org/r/#/c/69125/

This addresses the comment "... although not sure why it should if the same cached html (with buggy dsr) is used by the serializer -- so, maybe something is off there as well ...." above.

Once these fixes are tested in rt testing and deployed in production, we should verify that the dirty diffs are fixed and resolve this bug.

Related URL: https://gerrit.wikimedia.org/r/69254 (Gerrit Change I6c047ac01bb99c8cd793fbd01db5777f560f492b)

https://gerrit.wikimedia.org/r/69254 (Gerrit Change I6c047ac01bb99c8cd793fbd01db5777f560f492b) | change APPROVED and MERGED [by jenkins-bot]

Fixed in production.

Related URL: https://gerrit.wikimedia.org/r/69597 (Gerrit Change I32c511d05d62dd31bb19fca21aff792ddc422331)