Page MenuHomePhabricator

Scribunto_LuaStandaloneEngine: Check disable_functions and safe_mode
Closed, ResolvedPublic

Description

People on shared hosts are trying to use Scribunto out of the box. We should check to see if disable_functions has proc_open in it, before attempting to execute that function, so that we can give an informative error message. Probably also safe_mode.


Version: unspecified
Severity: normal

Details

Reference
bz50706

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:10 AM
bzimport set Reference to bz50706.
bzimport added a subscriber: Unknown Object (MLST).

Change 72089 had a related patch set uploaded by Anomie:
Improve disable_functions handling in LuaStandalone

https://gerrit.wikimedia.org/r/72089

Change 72089 merged by jenkins-bot:
Improve disable_functions handling in LuaStandalone

https://gerrit.wikimedia.org/r/72089

Change 95412 had a related patch set uploaded by MarkAHershberger:
Improve disable_functions handling in LuaStandalone

https://gerrit.wikimedia.org/r/95412

Change 95412 abandoned by MarkAHershberger:
Improve disable_functions handling in LuaStandalone

https://gerrit.wikimedia.org/r/95412

No open patches to review here (backport patches got abandoned), hence resetting status to RESOLVED FIXED. Backport_to_Stable flag might be set to "-" by hexmode.