Page MenuHomePhabricator

Possible bug in selser changes generation
Closed, ResolvedPublic

Description

Investigate why some parser tests have an empty selser changes array. This could be a bug in the selser changes generation code. Some of the tests (redirect or php-only) wont have any selser changes, but unsure why some others dont have. To be investigated.

[subbu@earth tests] egrep ":\[\]," selser.changes.json | grep -v php | wc

29     287    2186

[subbu@earth tests] egrep ":\[\]," selser.changes.json | grep -v php | head
"Parsoid only: Quote balancing context should be restricted to td/th cells on the same wikitext line\n(Requires tidy for PHP parser output to be fixed up)":[],
"Parsoid: Pipe in external link target and content in template parameter":[],
"Templates: Dont escape already nowiki-escaped text in template parameters":[],
"Implicit <td> after a |-\n(PHP parser relies on Tidy to add the missing <td> tags)":[],
"Pres should be recognized in an explicit <td> context, but not in an implicit <td> context\n(PHP parser relies on Tidy to add the missing <td> tags)":[],
"Lists should be recognized in an implicit <td> context\n(PHP parser relies on Tidy to add the missing <td> tags)":[],
"Parsoid link trail escaping":[],
"Parsoid link prefix escaping":[],
"Redirect to category":[],
"Redirect to category page":[],


Version: unspecified
Severity: normal

Details

Reference
bz50982

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:00 AM
bzimport added a project: Parsoid-Tests.
bzimport set Reference to bz50982.
ssastry created this task.Jul 8 2013, 9:44 PM

Change 76636 had a related patch set uploaded by Arlolra:
Avoid filtering out selser tests.

https://gerrit.wikimedia.org/r/76636

Change 76636 had a related patch set uploaded by Arlolra:
Avoid filtering out selser tests.

https://gerrit.wikimedia.org/r/76636

Change 76636 merged by jenkins-bot:
(Bug 50982) Fix for empty selser changes arrays.

https://gerrit.wikimedia.org/r/76636