Broken table, repeated section in diff after VisualEditor edit
Closed, ResolvedPublic

Description

I recently ran across [https://en.wikipedia.org/w/index.php?title=Polycarbonate&diff=prev&oldid=564618311 this edit]. It seems as though they were trying to fix a spelling correction and inadvertently destroyed a table and had an entire section get repeated.

There was a little [https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Strange_Diff discussion about the diff on the Visual Editor feedback page], where it was mentioned that the diff "is very strange and [the commenter didn't] recall seeing anything similar".


Version: unspecified
Severity: normal

bzimport added a project: Parsoid-Serializer.Via ConduitNov 22 2014, 1:56 AM
bzimport set Reference to bz51772.
Zellfaze created this task.Via LegacyJul 21 2013, 2:18 PM
ssastry added a comment.Via ConduitJul 22 2013, 3:20 PM

The problem is that the table wikitext is buggy there. It is missing a closing tag (in reality, it is missing a newline break. |-|} .. See https://en.wikipedia.org/w/index.php?title=Polycarbonate&action=edit&oldid=563700122)

The PHP parser output for this is also broken (see https://en.wikipedia.org/w/index.php?title=Polycarbonate&oldid=563700122#Manufacturers_and_brands and where the table has ended up).

We could improve Parsoid to detect some scenarios like this, but it is currently lower priority. Fixing the table by adding a line break between "|-" and "|}" should fix the issue for now.

Sample wikitext snippet for our use later:

{|

foo
-}

abc

Jdforrester-WMF added a comment.Via ConduitOct 10 2014, 9:48 PM

This was fixed a very long time ago (around August last year), but I didn't spot this report until just now; my apologies.

Jdforrester-WMF set Security to None.

Add Comment