Page MenuHomePhabricator

TemplateData: Fix "TypeError: Cannot read property 'content' of undefined" (when applying template changes)
Closed, ResolvedPublic

Description

Looks like we don't account for the API returning an error in ve.ce.MWTransclusionNode.prototype.generateContents. Unconditionally response.visualeditor.content is accessed.

API has a clear path both for dieUsage() and result === success.


Version: unspecified
Severity: normal

Details

Reference
bz52483

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:48 AM
bzimport set Reference to bz52483.
Krinkle created this task.Aug 2 2013, 10:33 PM

Change 77460 had a related patch set uploaded by Krinkle:
ve.ce.MWTransclusionNode: Check for API errors

https://gerrit.wikimedia.org/r/77460

Change 77460 merged by jenkins-bot:
ve.ce.MWTransclusionNode: Check for API errors

https://gerrit.wikimedia.org/r/77460