Page MenuHomePhabricator

weird &1 in HTML comment
Closed, ResolvedPublic

Description

<!-- Message sent by User:Eloquence@testwiki using the list at //test.wikipedia.org/w/index.php?title=User:Eloquence/MM&1 -->

The &1 shouldn't be there.

echo Title::newFromText('Main Page')->getFullURL();

http://127.0.0.1:8080/wiki/Main_Page

echo Title::newFromText('Main Page')->getFullURL($proto = PROTO_CANONICAL);

http://127.0.0.1:8080/w/index.php?title=Main_Page&1

I think this is because I didn't realize PHP doesn't support out of order kwargs like python does.


Version: unspecified
Severity: normal

Details

Reference
bz54955

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:39 AM
bzimport added a project: MassMessage.
bzimport set Reference to bz54955.

Change 87509 had a related patch set uploaded by Legoktm:
Use PROTO_CANONICAL correctly.

https://gerrit.wikimedia.org/r/87509

Change 87509 merged by jenkins-bot:
Use PROTO_CANONICAL correctly.

https://gerrit.wikimedia.org/r/87509