Make the Claims list not depend on hashes
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	daniel
	Oct 10 2013, 4:45 PM

Description

Claim hashes are not unique, so the Claims object should be oblivious to them. Claims should instead assure that Claim GUIDs are unique in the list.

Version: unspecified
Severity: normal

Details

Reference: bz55569

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:24 AM

• bzimport added a project: MediaWiki-extensions-WikibaseRepository.

• bzimport set Reference to bz55569.

• bzimport added a subscriber: Unknown Object (MLST).

daniel created this task.Oct 10 2013, 4:45 PM

Some more background: In particular, Claims::getDiff was using a hash based lookup that would result in invalid diffs and cause failed assertions in some cases.

Change 89015 had a related patch set uploaded by Daniel Kinzler:
(bug #55569) Make Claims list not use hashes.

https://gerrit.wikimedia.org/r/89015

Change 89016 had a related patch set uploaded by Daniel Kinzler:
(bug #55569) Fix tests after Claims no longer use hashes.

https://gerrit.wikimedia.org/r/89016

Change 89015 merged by Jeroen De Dauw:
(bug #55569) Make Claims list not use hashes.