Page MenuHomePhabricator

Improve timeout handling on pages that take a long time to parse?
Closed, ResolvedPublic

Description

Try fr/Liste_des_premiers_préfets_français_(1800-1815) locally. The output is different each time. The serialized (html2wt) output also has minor diffs. This seems like possible bugs in timeout handling. This page has a ton of template requests (some of which are responsible for closing tables) and timeouts in those can affect DOM. So, we need a way of dealing with the volume of requests to minimize timeout scenarios.


Version: unspecified
Severity: normal

Details

Reference
bz55585

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:25 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz55585.

Change 91554 had a related patch set uploaded by Arlolra:
Increase maxSockets for ApiRequests

https://gerrit.wikimedia.org/r/91554

Change 91554 merged by jenkins-bot:
Generate less timeouts on pages that make a lot of API requests

https://gerrit.wikimedia.org/r/91554

Subbu, let me know if those merged changes are enough to close this ticket.

Perhaps visit parsoid.wmflabs.org:8001 (our rt testing server), look at perf stats, sort by parse times and verify time changes on a few of the worst pages there. That link is currently unresponsive and the RT server might need a restart or something.

ok, here are the four worst offenders on that list.

master

completed parsing of en:Russia_at_the_2004_Summer_Olympics in 33357 ms
completed parsing of ja:堺ブレイザーズの歴代選手・スタッフ一覧 in 17156 ms
completed parsing of it:Medagliati_olimpici_nell'atletica_leggera_-_Uomini in 21816 ms
completed parsing of it:Eccellenza_Lombardia_2011-2012 in 25213 ms

51d49eb7584a57c459d6409545e299ce61a3c34a (current commit of rt server)

completed parsing of en:Russia_at_the_2004_Summer_Olympics in 106482 ms
completed parsing of ja:堺ブレイザーズの歴代選手・スタッフ一覧 in 66233 ms
completed parsing of it:Medagliati_olimpici_nell'atletica_leggera_-_Uomini in 150488 ms
completed parsing of it:Eccellenza_Lombardia_2011-2012 in 56719 ms

Awesome. I think we can now close this ticket :)