Page MenuHomePhabricator

drop obtrusive style rule for the <q> element
Closed, ResolvedPublic

Description

skins/common/commonElements.css currently contains a rather obtrusive style rule that messes up font rendering:

q {
font-family: Times, "Times New Roman", serif;
font-style: italic;
}

This is very old code that has been present long before <q> was allowed in wikitext. I suspect that it was added because IE <= 7 doesn't insert quotation marks around <q>, as it should. So the rule was put in to make quotes at least somehow recognizable.

I don't think this is still justified (IE >= 8 and all other browsers insert quotation marks properly). The rule should be dropped or at least a CSS hack should be used to hide it from modern browsers.


Version: 1.22.0
Severity: minor

Details

Reference
bz55591

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:25 AM
bzimport set Reference to bz55591.
Entlinkt created this task.Oct 10 2013, 9:00 PM

Change 89174 had a related patch set uploaded by Bartosz Dziewoński:
Remove obtrusive styles for <q>

https://gerrit.wikimedia.org/r/89174

Change 89174 merged by jenkins-bot:
Remove obtrusive styles for <q>

https://gerrit.wikimedia.org/r/89174