Page MenuHomePhabricator
Create Task
Maniphest T57798

CirrusSearch blows up on really really long queries in production
Closed, ResolvedPublic
Actions

Description

CirrusSearch fails on really really long queries like this:
asdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffasdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffasdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffasdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff

Version: unspecified
Severity: normal

Details

Reference
bz55798

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:40 AM
• bzimport added a project: CirrusSearch.
• bzimport set Reference to bz55798.
• bzimport added a subscriber: Unknown Object (MLST).
• Manybubbles created this task.Oct 16 2013, 4:55 PM
• Manybubbles added a comment.Oct 16 2013, 4:58 PM

But this doesn't seem to happen in dev.

• Manybubbles added a comment.Oct 16 2013, 6:42 PM

This is caused by pcre backtracking - in prod we must have the limit lower than in dev. Either way, I'll remove the offending regex and replace it with a loop over the characters. It'll probably be faster any way.

gerritbot added a comment.Oct 16 2013, 8:41 PM

Change 90200 had a related patch set uploaded by Manybubbles:
Improvements when searching long strings

https://gerrit.wikimedia.org/r/90200

gerritbot added a comment.Oct 16 2013, 8:43 PM

Change 90202 had a related patch set uploaded by Manybubbles:
Tests for unbalanced quotes

https://gerrit.wikimedia.org/r/90202

gerritbot added a comment.Oct 16 2013, 8:57 PM

Change 90200 merged by jenkins-bot:
Improvements when searching long strings

https://gerrit.wikimedia.org/r/90200

gerritbot added a comment.Oct 16 2013, 8:57 PM

Change 90202 merged by jenkins-bot:
Tests for unbalanced quotes

https://gerrit.wikimedia.org/r/90202

• Deskana moved this task from Inbox to Resolved/Invalid/Declined/Legacy on the CirrusSearch board.Apr 20 2015, 4:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits