Page MenuHomePhabricator

Defect: Blocks on user should be checked by ipb_user instead of ipb_address
Closed, DeclinedPublicBUG REPORT

Description

+++ This bug was initially created as a clone of Bug #57481 +++

It seems old Extension:Renameuser didn't update ipb_address correctly, leaving many incorrect ipb_address values in database.

This also affects newly renamed users (due to job queue).

The method of trying to join user table is already used in revision table etc.


Version: 1.23.0
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57481
https://bugzilla.wikimedia.org/show_bug.cgi?id=3279

Details

Reference
bz57482

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:39 AM
bzimport set Reference to bz57482.
bzimport added a subscriber: Unknown Object (MLST).

Brion mentioned in bug 3279 that "the actual block works based on the user ID number" but it seems not the case (anymore?).

Searching for ipb_user in Block.php returns only one usage, in the function to insert new block rows.

Actually there're already reports from users saying that they're accidentially blocked, and the real cause is that they usurped an originally blocked user name in the past, and ipblocks table still stores the user name having been usurped because of (the broken-in-the-past and already-fixed) RenameUser extension.

Bumping severity because this causes legitimate users to be (at least practically) blocked.

(In reply to comment #3)

Sounds like bug 23135

Not really. This bug says "MediaWiki shouldn't be trapped by data messed up by Extension:Renameuser due to bug 23135".

TBolliger renamed this task from Blocks on user should be checked by ipb_user instead of ipb_address to Defect: Blocks on user should be checked by ipb_user instead of ipb_address.Jan 12 2018, 11:12 PM
Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 15 2022, 9:39 PM
Aklapper removed a subscriber: wikibugs-l-list.