Page MenuHomePhabricator

[global abuse filters] Wikimania 2013 and Wikimania2014 to be added to wikis with this functionality
Closed, ResolvedPublic

Description

Would, at your convenience, please be able to add both Wikimania2014
and Wikimania2013 to the set of wikis that utilise the global abuse filters at meta.

Local discussions
https://wikimania2014.wikimedia.org/w/index.php?title=Wikimania:Information_Desk&oldid=5094
https://wikimania2013.wikimedia.org/w/index.php?title=Wikimania:Information_Desk&oldid=26602

Thanks.


Version: wmf-deployment
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=59157

Details

Reference
bz59711

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:21 AM
bzimport set Reference to bz59711.
bzimport added a subscriber: Unknown Object (MLST).
Dzahn added a comment.Jan 6 2014, 10:24 AM

looks like it needs a gerrit patch in repo mediawiki-config/wmf-config in abusefilter.php , right? There is a switch/case in there with one case per wiki and they list a different number of wgGroupPermissions. line 30 ff. "Custom permissions". The historic shell keyword may be misleading a bit nowadays because it would be regular gerrit and after that deployment.

that is what occurred last time, and Chris handled it when he had time.

Change 105655 had a related patch set uploaded by TTO:
Add Wikimania wikis to global abuse filters

https://gerrit.wikimedia.org/r/105655

TTO added a comment.Jan 6 2014, 10:36 AM

(In reply to comment #1)

The historic shell keyword may be misleading a bit
nowadays because it would be regular gerrit and after that deployment.

Slightly offtopic, but yes I wish the "shell" keyword was only used for things that volunteers can't submit to gerrit, like requests to run maintenance script. That way it would help to focus what bugs the shell users themselves need to go and work on.

Dzahn added a comment.Jan 6 2014, 10:38 AM

ah, just in InitialiseSettings? if yea then ignore my uninformed comment about editing abusefilter.php itself. It just looked like wikis are listed there as well each having a case.

and re: the shell keyword. Yes i agree, i have suggested in the past that "ops" is used when we really mean only roots can do it, "shell" when it needs software deployment (engineering but not necessarily ops) and just "patch" or something when anyone with gerrit could start working on it. Once there is a patch it could be changed to "deployment" or so.

Okay, about skipping or not Wikimania2013, if it is closing, that is fine. Last year W12 stayed open for a whole year afterwards.

If it is spammed before it is closed, so be it, it will deleted or not.

Slightly offtopic, but yes I wish the "shell" keyword

Please discuss in bug 45539.

Change 105655 merged by jenkins-bot:
Add Wikimania 2014 wiki to global abuse filters

https://gerrit.wikimedia.org/r/105655

Looks like wikimania2013 is remaining open and it is still getting spambots, so can we please reconsider the addition to global abuse filters. Link above to conversation keeping wikimania2013 open

(In reply to comment #9)

Looks like wikimania2013 is remaining open and it is still getting spambots,
so
can we please reconsider the addition to global abuse filters. Link above to
conversation keeping wikimania2013 open

Not necessary I think as all the wikimania wikis are included in the "small wikis" package (see https://github.com/wikimedia/operations-mediawiki-config/blob/master/small.dblist), and the small wikis are already added to the global filter (bug 60408)

Closing as RESOLVED FIXED per Trijnstel.