Page MenuHomePhabricator

Images get stretched over the whole screen on first view.
Closed, ResolvedPublic

Description

Author: aarcos.wiki

Description:
Repo steps:
0) Got to https://www.mediawiki.org/wiki/Lightbox_demo#

  1. Click on the first image, the MV should come up.
  2. Press the next button. The image of a shell appears stretched over the whole screen, see picture in:

https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/102

  1. Go back and forth again and the image appears in "normal" proportions again.

After some preliminary investigations this looks like a race condition but more digging is necessary.


Version: master
Severity: blocker
Platform: Macintosh

Details

Reference
bz60173

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:02 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz60173.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Jan 17 2014, 5:56 PM

aarcos.wiki wrote:

This seems to be Mac OS specific but I was able to repro in Chrome and Firefox.

Change 109268 had a related patch set uploaded by Aarcos:
Fix to streching image b/60173. It seems the problem was iOS specific. In retina displays the devicePixelRatio turns out to be 2. This was making the images twice as wide. This was introduced as a way to fix the resolution problem with some Apple device

https://gerrit.wikimedia.org/r/109268

Change 109268 merged by jenkins-bot:
Fix to streching image b/60173. It seems the problem was iOS specific. In retina displays the devicePixelRatio turns out to be 2. This was making the images twice as wide. This was introduced as a way to fix the resolution problem with some Apple device

https://gerrit.wikimedia.org/r/109268

aarcos.wiki wrote:

This bug was introduced by https://gerrit.wikimedia.org/r/#/c/95282/

Gilles moved this task from Untriaged to Done on the Multimedia board.