Page MenuHomePhabricator

status bar reports "Finished!" long before upload is finished
Closed, ResolvedPublic

Description

seen on http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard

upload any file. Watch the status bar.

About halfway through the load, "Finished!" appears.

"Finished!" should appear only after the status bar completes, and only if the upload actually finishes correctly.


Version: unspecified
Severity: normal

Details

Reference
bz60483

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz60483.
bzimport added a subscriber: Unknown Object (MLST).
Gilles triaged this task as High priority.Nov 24 2014, 2:55 PM
Gilles added a subscriber: Gilles.
Gilles moved this task from Untriaged to Prototyping on the Multimedia board.Nov 24 2014, 4:06 PM
Gilles moved this task from Prototyping to Next up on the Multimedia board.Dec 3 2014, 5:46 PM

Change 177298 had a related patch set uploaded (by MarkTraceur):
Add "almost finished" message

https://gerrit.wikimedia.org/r/177298

Patch-For-Review

Gilles assigned this task to MarkTraceur.Dec 4 2014, 8:52 AM

2014-12-05 - 10:21:46 <+marktraceur> gi11es: I don't see anything terribly wrong on my side, using several 30+MB OGV files..."almost finished" lasts for maybe a few seconds, but I think we can attribute that to slight inaccuracies in the guessing algorithm.
2014-12-05 - 10:22:32 <+marktraceur> You can only be so accurate when you're estimating based on the historical rates during the session

From IRC, not sure if Gilles is paying attention or not.

I have experienced this issue a number of times on my end, even with relatively small files.

Here's a screenshot of a recent case, where the file was 2.2 Mb (see attached screenshot).

@Fabrice_Florin I think you're showing us a screenshot from master. We're discussing the situation after having applied the linked patch.

@Gilles can you respond? I'm not sure what exactly is going on with your computer, but I can't repro. Maybe it's a browser thing? Are you on Chrome?

Change 177298 merged by jenkins-bot:
Add "almost finished" message and remove parseInts

https://gerrit.wikimedia.org/r/177298

Gilles moved this task from Ready for testing to Doing on the Multimedia board.Dec 10 2014, 4:28 PM
Gilles moved this task from Doing to Done on the Multimedia board.Dec 10 2014, 10:19 PM
Gilles closed this task as Resolved.