Page MenuHomePhabricator

Persian LanguageFa.php hardcodes project namespace as Wikipedia
Closed, ResolvedPublic

Description

This breaks all non-Wikipedia languages set to Persian (fa.wikibooks, fa.wikisource, etc).


Version: 1.6.x
Severity: normal

Details

Reference
bz4413

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:01 PM
bzimport set Reference to bz4413.
bzimport added a subscriber: Unknown Object (MLST).

kaveh_d wrote:

I see what the problem is now. If I were to submit a patch, what should I change
the instances of "Wikipedia" in LanguageFa.php to?

gangleri wrote:

Use "Project:" wherever "Wikipedia" is used.

gangleri wrote:

(In reply to comment #2)

Use "Project:" wherever "Wikipedia" is used.

Use "Project:" wherever "Wikipedia:" is used. (now both are with colon ":")

zigger wrote:

LanguageFa.php patch for HEAD

attachment LanguageFa.php.patch ignored as obsolete

kaveh_d wrote:

I am looking at LanguageHe, and in some instances they've used {{ns:project}}
and in others {{SITENAME}}. What's the distintion here?

zigger wrote:

(After exchanging emails with Kaveh (thanks), I'm continuing with the patch.)

{{SITENAME}} is for display only, and "{{ns:project}}:" is better than
"Project:" as it will use the translation during rendering.

zigger wrote:

LanguageFa.php patch for HEAD

Changes:
o Small white-space fix
o fixes the hard-coded Project namespaces
o translates the Template, Help, and Category namespaces
o uses {{ns:project}} and {{SITENAME}} instead of hard-coding
o ensures that passwordreminder messages are inherited
o improves the welcomecreation message

(Thanks to Kaveh for the translations and checking.)

Not done (& won't be done by me):
o testing
o comparisons with Special:Allmessages on fa sites
o translation/removal of messages in English
o translations of missing messages
o checking/fixing pseudo-namespaces on fa sites

attachment LanguageFa.php.3.patch ignored as obsolete

zigger wrote:

LanguageFa.php patch for HEAD

Fixed list typo.

Attached:

jeluf wrote:

Fixed in CVS, LanguageFa.php, rev 1.51.