Page MenuHomePhabricator

Notice: Undefined variable: file_extension_length
Closed, ResolvedPublic

Description

sample dataset

the extension does not set the variable to an initial value, so that when the code reaches line 412 it has not been set. also, the test on line 408 needs to test the strlen() of the $result, which it does not.

in order to see the PHP Notice, you need to have GWToolset installed in an
environment that has error_reporting set to E_STRICT|E_ALL.

once logged in and at Step 1: Metadata detection

step 1

  1. nothing to add
  2. select Artwork
  3. nothing to add
  4. nothing to add
  5. choose the attached sample dataset.

step 2

  1. map the following fields title identifier => dc:identifier url to the media file => europeana:object
  2. press the "Preview batch" button

step 3

  1. click on one of the resulting files
  2. notice the PHP Notice: Undefined variable: file_extension_length in /extensions/GWToolset/includes/Models/MediawikiTemplate.php on line 412

Version: unspecified
Severity: normal

Attached:

Details

Reference
bz64086

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:16 AM
bzimport set Reference to bz64086.
bzimport added a subscriber: Unknown Object (MLST).
dan-nl created this task.Apr 18 2014, 8:33 AM

Change 127211 had a related patch set uploaded by Dan-nl:
fix MediawikiTemplate::getTitle() method

https://gerrit.wikimedia.org/r/127211

Change 127211 merged by jenkins-bot:
fix MediawikiTemplate::getTitle() method

https://gerrit.wikimedia.org/r/127211

Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:23 AM