Page MenuHomePhabricator

Passing empty string (like null) to MemcachedPhpBagOStuff::get disables memcached for rest of the request
Closed, ResolvedPublic

Description

I was debugging why I got stale data from cache. Turns out memcached was disabled due to an error which was caused by sending "gets " to it at some point. This prevented updating of the cache key on later call.


Version: 1.23.0
Severity: major

Details

Reference
bz64287

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz64287.

Change 129174 had a related patch set uploaded by Nikerabbit:
Handle empty keys in MWMemcached

https://gerrit.wikimedia.org/r/129174

Change 132176 had a related patch set uploaded by MarkAHershberger:
Handle empty keys in MWMemcached

https://gerrit.wikimedia.org/r/132176

Change 132177 had a related patch set uploaded by MarkAHershberger:
Handle empty keys in MWMemcached

https://gerrit.wikimedia.org/r/132177

Change 132178 had a related patch set uploaded by MarkAHershberger:
Handle empty keys in MWMemcached

https://gerrit.wikimedia.org/r/132178

Change 132178 abandoned by MarkAHershberger:
Handle empty keys in MWMemcached

Reason:
missed aaron's review

https://gerrit.wikimedia.org/r/132178

Change 132177 abandoned by MarkAHershberger:
Handle empty keys in MWMemcached

Reason:
missed aaron's review

https://gerrit.wikimedia.org/r/132177

Change 132176 abandoned by MarkAHershberger:
Handle empty keys in MWMemcached

Reason:
missed aaron's review

https://gerrit.wikimedia.org/r/132176

Change 129174 merged by jenkins-bot:
Don't die on empty keys in MWMemcached

https://gerrit.wikimedia.org/r/129174

Assuming fixed, test/reproduction welcome. Request for backport still open (no opinion from me).

I'd be in favor of this backport, but gerrit isn't letting me cherry pick because of previous abandoned cherry picks.