Page MenuHomePhabricator

OOjs UI: Auto-disabled tool group still responds to clicks
Closed, ResolvedPublic

Description

  • Go to the tools demo
  • Click "auto-disabling list"
  • Click "click to disable this tool"
  • "auto-disabling list" now appears greyed out
  • Click "auto-disabling list"
  • An active effect appears, even though the dropdown is disabled and you can't interact with it at all

Other disabled toolgroups don't have this problem, it's only the one that gets disabled dynamically.

This causes a bug in VisualEditor as well: click out of the editor (this disables most tools and auto-disables the Insert toolgroup), then click Insert. An active effect appears.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64601

Details

Reference
bz64759

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:08 AM
bzimport added a project: OOUI.
bzimport set Reference to bz64759.

Change 131120 had a related patch set uploaded by Trevor Parscal:
Use .isDisabled() instead of .disabled to support inheriting

https://gerrit.wikimedia.org/r/131120

Is this a duplicate of Bug 64601 ?

Change 131120 merged by jenkins-bot:
Use .isDisabled() instead of .disabled to support inheriting

https://gerrit.wikimedia.org/r/131120

(In reply to Rainer Rillke @commons.wikimedia from comment #2)

Is this a duplicate of Bug 64601 ?

No; bug 64434.