Maniphest T68329

Ignore events with modifier keys
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Jun 7 2014, 6:22 PM

Tags

Referenced Files

None

Subscribers

• Fabrice_Florin

• wikibugs-l-list

Tokens

"Grey Medal" token, awarded by RandomDSdevel.

Description

We ignore some events with modifier keys (e.g. shift-click); we should do that consistently all the time. For example, some people apparently bind special functions to Alt-up, which conflicts with the metadata panel keydown handler: https://www.mediawiki.org/w/index.php?title=Talk:Multimedia/About_Media_Viewer&diff=1026325&oldid=1026318

Version: unspecified
Severity: normal

Details

Reference: bz66329

	Subject	Repo	Branch	Lines +/-
	Ignore events with modifier keys	mediawiki/extensions/MultimediaViewer	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: rMEXTa54093cb755c: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer…
rEMMVdb01284c6e08: Ignore events with modifier keys

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:25 AM

• bzimport added a project: MediaViewer.

• bzimport set Reference to bz66329.

• bzimport added a subscriber: Unknown Object (MLST).

Tgr created this task.Jun 7 2014, 6:22 PM

MarkTraceur triaged this task as Medium priority.Nov 24 2014, 1:55 PM

MarkTraceur set Security to None.

• Gilles added a project: Multimedia.Nov 24 2014, 3:16 PM

Tgr added projects: Technical-Debt, good first task.Dec 11 2014, 2:37 AM

GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5857795584819200

Change 182052 had a related patch set uploaded (by Unicodesnowman):
Ignore events with modifier keys

https://gerrit.wikimedia.org/r/182052

Patch-For-Review

Unicodesnowman closed this task as Resolved.Dec 29 2014, 8:33 AM

Unicodesnowman claimed this task.

Change 182052 merged by jenkins-bot:
Ignore events with modifier keys

https://gerrit.wikimedia.org/r/182052

Unicodesnowman mentioned this in rEMMVdb01284c6e08: Ignore events with modifier keys.Dec 29 2014, 8:34 AM

RandomDSdevel awarded a token.Mar 4 2015, 7:43 PM

Unicodesnowman mentioned this in rMEXTa54093cb755c: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer….Mar 11 2015, 6:23 AM