Page MenuHomePhabricator
Create Task
Maniphest T69045

SpecialPageFactory::getTitleForAlias always throws exception
Closed, ResolvedPublic
Actions

Description

It calls resolveAlias, gets an array back, then calls getTitleFor with the result. getTitleFor expects a string, so always throws an exception.

We can either fix getTitleForAlias (just call getTitleFor) with the first element of the array returned by resolveAlias), or delete it and its sole usage in the deprecated function SpecialPage::getTitleForAlias

Version: 1.24rc
Severity: normal

Details

Reference
bz67045

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:37 AM
• bzimport added a project: MediaWiki-Special-pages.
• bzimport set Reference to bz67045.
• bzimport added a subscriber: Unknown Object (MLST).
Ejegg created this task.Jun 24 2014, 6:52 PM
gerritbot added a comment.Jun 24 2014, 9:42 PM

Change 141845 had a related patch set uploaded by Ejegg:
Fix SpecialPageFactory::getTitleForAlias

https://gerrit.wikimedia.org/r/141845

gerritbot added a comment.Sep 12 2014, 6:37 PM

Change 141845 merged by jenkins-bot:
Fix SpecialPageFactory::getTitleForAlias

https://gerrit.wikimedia.org/r/141845

Umherirrender added a comment.Sep 12 2014, 6:37 PM

successfully merged

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits