Page MenuHomePhabricator

EducationProgram dies if cldr is required after it
Closed, ResolvedPublic

Description

EducationProgram dies whenever it is missing the cldr extension which it relies on. To run unit tests in Jenkins, we clone the extensions and have them loaded using scandir() which can yield EducationProgram before cldr. The tests thus abort because EducationProgram.php is loaded first.

Seems the EducationProgram entry points does do that much and we have a SetupAfterCache hook in Setup.php which could be used to implement the check. The hook run after LocalSettings and all require_once(extensions/*) has been completed so that should be safe.

That prevents us from enrolling EducationProgram in a massive jenkins job that tests all extensions together (bug 67216).


Version: unspecified
Severity: normal

Details

Reference
bz67598

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:39 AM
bzimport set Reference to bz67598.
hashar created this task.Jul 7 2014, 3:39 PM

Change 144464 had a related patch set uploaded by Hashar:
Delay check of cldr presence after Setup

https://gerrit.wikimedia.org/r/144464

hashar added a comment.Jul 7 2014, 3:48 PM

High because that prevent us from running tests properly and blocks somehow HHVM progress.

Change 144464 merged by jenkins-bot:
Delay check of cldr presence after Setup

https://gerrit.wikimedia.org/r/144464