Page MenuHomePhabricator

JS cleanup: use data-api-target (in template) instead of seeking out specific nodes in JS
Closed, ResolvedPublic

Description

In order to wrap up frontend changes sonner rather than later, some corners were cut. The plan was to avoid finding specific nodes in JS code, but rather have selectors etc in the templates.

Try searching for .closest( 'form' ) in flow-board.js, for example ;)

Here's an incomplete list of stuff that definitely needs fixing. Please help complete this list & fix the code ;)

  • Error handling: FlowBoardComponent.UI.events.interactiveHandlers.apiRequest has generic error handling, but always attached the error message to $this.closest( 'form' ) - even though errors can occur without relevant forms (e.g. FlowBoardComponent.UI.events.apiHandlers.board, which has to manually attach the errors because the generic error handling assumes form...)

Version: unspecified
Severity: normal

Details

Reference
bz68021

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:31 AM
bzimport set Reference to bz68021.
bzimport added a subscriber: Unknown Object (MLST).

Change 146785 had a related patch set uploaded by Matthias Mullie:
Fix error handling

https://gerrit.wikimedia.org/r/146785

Change 146785 merged by jenkins-bot:
Fix error handling

https://gerrit.wikimedia.org/r/146785

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:34 AM