Page MenuHomePhabricator

black text on blue background when i keydown on suggestions menu
Closed, ResolvedPublic

Description

when i keydown (down arrow) on suggestions menu when entering properties, the suggestions are black text with blue background, thus difficult to read.

when i mouse over, they are white text and blue background.

this happens on master and test.wikidata


Version: unspecified
Severity: normal

Details

Reference
bz68386

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:39 AM
bzimport set Reference to bz68386.
bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Jul 22 2014, 5:18 PM
aude added a comment.Jul 22 2014, 6:42 PM

on test.wikidata, seems to work correctly in debug mode so indicates possibly a problem with resource loader definitions or caching (?)

on my local dev wiki, though, it is broken in debug mode and non-debug mode so might be some other problem.

aude added a comment.Jul 22 2014, 7:28 PM

possible solutions include to remove 'color: black' in jquery.ui.suggester.css

https://github.com/wmde/ValueView/blob/master/lib/jquery.ui/jquery.ui.suggester.css#L29

or remove .ui-ooMenu-item from line 28

If removing color: black, then the styles inherit black (when not hovering or keydown) from .ui-widget-content a in jquery.ui.theme.css and is white when hovering or keydown. (e.g. doing right thing)

aude added a comment.Jul 22 2014, 7:51 PM

https://github.com/wmde/ValueView/pull/89 is what I propose for ValueView, although sure there are other ways to fix also.

https://www.wikidata.org/wiki/User:Aude/common.css seems to work as temporary fix, although might also be caching weirdness. Editing site css is evil though and would be better to wait for proper fix, probably tomorrow.

Change 148656 had a related patch set uploaded by Aude:
New deployment build, fix css issue in entity, sitelink... suggester

https://gerrit.wikimedia.org/r/148656

Change 148656 merged by jenkins-bot:
New deployment build, fix css issue in entity, sitelink... suggester

https://gerrit.wikimedia.org/r/148656

Change 148670 had a related patch set uploaded by Aude:
Update Wikidata to fix css issue in suggester

https://gerrit.wikimedia.org/r/148670

Change 148670 merged by Reedy:
Update Wikidata to fix css issue in suggester

https://gerrit.wikimedia.org/r/148670