Page MenuHomePhabricator

Echo: TypeError: mw.echo.overlay.updateCount is not a function - when loading more at Special:Notifications
Closed, ResolvedPublic

Description

screenshot

Initially at http://ee-flow.wmflabs.org/wiki/Special:Notifications
I clicked "More..." and it loaded one batch.
I clicked "More..." again, but nothing happened.
I opened web-console, and saw the error message:
"TypeError: mw.echo.overlay.updateCount is not a function"

I then hard-refreshed the page. This time, I was able to load 2 additional batches. After that, nothing happened. The same error message was shown in web-console. (Screenshot)

I then hard-refreshed the page, and all old notifications loaded successfully.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz69714

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz69714.
bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.Aug 18 2014, 8:44 PM

I'm getting this on mediawiki.org. Tantalizingly I'm also seeing "No formatting defined for notification" from the flyout (G-102), and I see this error on Special:Notifications when I get close to loading notifications around the same time.

It *doesn't* go away on refresh or appending ?debug=1. I also had to click [More...] more times to reproduce the second time, but maybe it's my volume of notifications.

The JavaScript error in ?debug=1 mode is
TypeError: mw.echo.overlay.updateCount is not a function
https://bits.wikimedia.org/static-1.24wmf20/extensions/Echo/modules/special/ext.echo.special.js
Line 136

Benny in IRC : "We updated overlay.js but didn't update the corresponding code in special.js"

Change 158790 had a related patch set uploaded by Spage:
mw.echo.overlay.updateCount() not longer exists

https://gerrit.wikimedia.org/r/158790

Change 159162 had a related patch set uploaded by Spage:
mw.echo.overlay.updateCount() no longer exists

https://gerrit.wikimedia.org/r/159162

Change 159162 abandoned by Spage:
mw.echo.overlay.updateCount() no longer exists

Reason:
sorry, hasn't been +2d yet on master.

https://gerrit.wikimedia.org/r/159162

Change 158790 merged by jenkins-bot:
mw.echo.overlay.updateCount() no longer exists

https://gerrit.wikimedia.org/r/158790

Change 159162 restored by EBernhardson:
mw.echo.overlay.updateCount() no longer exists

Reason:
master was +2'd

https://gerrit.wikimedia.org/r/159162

Change 159162 merged by jenkins-bot:
mw.echo.overlay.updateCount() no longer exists

https://gerrit.wikimedia.org/r/159162

Working fine on mediawiki.org