Page MenuHomePhabricator
Create Task
Maniphest T71714

Echo: TypeError: mw.echo.overlay.updateCount is not a function - when loading more at Special:Notifications
Closed, ResolvedPublic
Actions

Description

screenshot

Initially at http://ee-flow.wmflabs.org/wiki/Special:Notifications
I clicked "More..." and it loaded one batch.
I clicked "More..." again, but nothing happened.
I opened web-console, and saw the error message:
"TypeError: mw.echo.overlay.updateCount is not a function"

I then hard-refreshed the page. This time, I was able to load 2 additional batches. After that, nothing happened. The same error message was shown in web-console. (Screenshot)

I then hard-refreshed the page, and all old notifications loaded successfully.

Version: unspecified
Severity: normal

Attached:

Screenshot_from_2014-08-18_10:54:52.png (1×1 px, 184 KB)

Details

Reference
bz69714

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:41 AM
• bzimport added a project: Notifications.
• bzimport set Reference to bz69714.
• bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.Aug 18 2014, 8:44 PM
• Spage added a comment.Sep 5 2014, 9:33 PM

I'm getting this on mediawiki.org. Tantalizingly I'm also seeing "No formatting defined for notification" from the flyout (G-102), and I see this error on Special:Notifications when I get close to loading notifications around the same time.

It *doesn't* go away on refresh or appending ?debug=1. I also had to click [More...] more times to reproduce the second time, but maybe it's my volume of notifications.

The JavaScript error in ?debug=1 mode is
TypeError: mw.echo.overlay.updateCount is not a function
https://bits.wikimedia.org/static-1.24wmf20/extensions/Echo/modules/special/ext.echo.special.js
Line 136

Benny in IRC : "We updated overlay.js but didn't update the corresponding code in special.js"

gerritbot added a comment.Sep 5 2014, 9:34 PM

Change 158790 had a related patch set uploaded by Spage:
mw.echo.overlay.updateCount() not longer exists

https://gerrit.wikimedia.org/r/158790

gerritbot added a comment.Sep 8 2014, 8:22 PM

Change 159162 had a related patch set uploaded by Spage:
mw.echo.overlay.updateCount() no longer exists

https://gerrit.wikimedia.org/r/159162

gerritbot added a comment.Sep 8 2014, 8:24 PM

Change 159162 abandoned by Spage:
mw.echo.overlay.updateCount() no longer exists

Reason:
sorry, hasn't been +2d yet on master.

https://gerrit.wikimedia.org/r/159162

gerritbot added a comment.Sep 8 2014, 8:44 PM

Change 158790 merged by jenkins-bot:
mw.echo.overlay.updateCount() no longer exists

https://gerrit.wikimedia.org/r/158790

gerritbot added a comment.Sep 8 2014, 8:45 PM

Change 159162 restored by EBernhardson:
mw.echo.overlay.updateCount() no longer exists

Reason:
master was +2'd

https://gerrit.wikimedia.org/r/159162

gerritbot added a comment.Sep 8 2014, 8:46 PM

Change 159162 merged by jenkins-bot:
mw.echo.overlay.updateCount() no longer exists

https://gerrit.wikimedia.org/r/159162

• Spage added a comment.Oct 1 2014, 12:47 AM

Working fine on mediawiki.org

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL