Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Go to Insert>Template
3.Click on "Show Options"
4.Add the template "Cite Web"
5.Select one of those required parameter from the left panel of the dialog
6.Add some more template with some optional parameters and content in the transclusion dialog
7.Now select one of the required parameter for the "Cite Web" template from the left panel
8.Now from left panel,select any other template/optional parameter/content or even the "Cite web" template

Observe that the trash icon that used to appear at the corner of the left panel for other template/optional parameter/content or "Cite web" template are not appearing now.

See the screenshots attached


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz70101

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:31 AM
bzimport set Reference to bz70101.
Ryasmeen created this task.Aug 27 2014, 7:46 PM

Created attachment 16297
The missing trash icon

Attached:

Change 156671 had a related patch set uploaded by Alex Monk:
Toggle trash button (on transclusion dialog) visibility when changing to non-parameter pages

https://gerrit.wikimedia.org/r/156671

Change 156671 merged by jenkins-bot:
Toggle trash button (on transclusion dialog) visibility when changing to non-parameter pages

https://gerrit.wikimedia.org/r/156671

Verified the fix in Betalabs

Verified the fix in test2

Verified the fix in production