Page MenuHomePhabricator

VisualEditor [Regression wmf20] Template dialog no longer displays added template fields' names
Closed, ResolvedPublic

Description

Missing template field name

On any page e.g. http://en.wikipedia.beta.wmflabs.org/wiki/0.2619265827018721?veaction=edit

Click Insert/Template

Type a name like "New template" and click "Add template"

In the resulting box, type "New template field" or some such.

Click the "Unknown field" to add the field to the template

Result should show "New template field" but instead is blank. Note that a "Remove field" icon is in place for the invisible template field.

See screen shot comparing beta labs with test2wiki.


Version: unspecified
Severity: major

Attached:

Details

Reference
bz70406

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:48 AM
bzimport set Reference to bz70406.

Renaming this.$label to something else (e.g. $labelElement) in modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js fixes this

If you keep it as $label, then add a parameter to a template, then get parameterPage.$label, it appears in place of the outline item widget's label.

Looks like the OOUI element mixin refactor is to blame...

gerritadmin wrote:

Change 158503 had a related patch set uploaded by Alex Monk:
Rename $label to $labelElement in MWParameterPage to avoid naming conflict

https://gerrit.wikimedia.org/r/158503

gerritadmin wrote:

Change 158503 merged by jenkins-bot:
Rename $label to $labelElement in MWParameterPage to avoid naming conflict

https://gerrit.wikimedia.org/r/158503

gerritadmin wrote:

Change 158508 had a related patch set uploaded by Jforrester:
Rename $label to $labelElement in MWParameterPage to avoid naming conflict

https://gerrit.wikimedia.org/r/158508

gerritadmin wrote:

Change 158508 merged by jenkins-bot:
Rename $label to $labelElement in MWParameterPage to avoid naming conflict

https://gerrit.wikimedia.org/r/158508

Should be fixed on master.

Seems to be working properly in beta labs now

Yes, working properly in Betalabs and test2

Verified the fix in production