Page MenuHomePhabricator

[1.24wmf20] Fatal error: Call to a member function getProperty() on a non-object, after completely history merging a page
Closed, ResolvedPublic

Description

  1. Module:Sandbox history splitted through delete & undelete.
  2. Merged full history of Module:Sandbox to Module:Pagebanner through Special:Mergehistory.
  3. Module:Sandbox fail. Full undeletion doesn't help.

Version: master
Severity: critical
URL: https://zh.wikivoyage.org/wiki/%E6%A8%A1%E5%9D%97:Sandbox

Details

Reference
bz70827

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz70827.

The error message is:

PHP fatal error in /srv/mediawiki/php-1.24wmf20/extensions/GeoCrumbs/GeoCrumbs.class.php line 126:
Call to a member function getProperty() on a non-object

getParserCache() can return null, but the code doesn't handle this situation, assuming it will never return null.

Change 160306 had a related patch set uploaded by Florianschmidtwelzow:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160306

Change 160306 merged by jenkins-bot:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160306

Change 160388 had a related patch set uploaded by Florianschmidtwelzow:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160388

Change 160389 had a related patch set uploaded by Florianschmidtwelzow:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160389

Change 160389 merged by jenkins-bot:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160389

Change 160388 merged by jenkins-bot:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160388

Patches merged to 1.24wmf21, 1.24wmf20 and master. Thanks! Closing as FIXED.

And deployed to wikivoyage :)