Page MenuHomePhabricator

mediawiki.action.view.redirect.js: Not idempotent when used on double redirect (refreshing the page redirects the user elsewhere)
Closed, ResolvedPublic

Description

mediawiki.action.view.redirect.js is not idempotent when used on double redirect, on a wiki where $wgMaxRedirects is 1 (the default). Refreshing the redirect page redirects the user further in the chain.

To reproduce, create redirect chain A → B → C, then visit A. Observe that you're seeing B. Refresh the page, you're seeing C now.

We probably need to add ?redirect=no to the URL in some cases.


Version: 1.24rc
Severity: minor

Details

Reference
bz71002

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:54 AM
bzimport set Reference to bz71002.
matmarex created this task.Sep 18 2014, 3:09 PM

This is apparently noticeable/problematic enough that people notice it and complain on VPT, so I guess I'm going to fix it myself…

Change 163465 had a related patch set uploaded by Bartosz Dziewoński:
Article: Handle double redirects in data for mediawiki.action.view.redirect

https://gerrit.wikimedia.org/r/163465

Change 163465 merged by jenkins-bot:
Article: Handle double redirects in data for mediawiki.action.view.redirect

https://gerrit.wikimedia.org/r/163465

Change 166446 had a related patch set uploaded by Bartosz Dziewoński:
Article: Handle double redirects in data for mediawiki.action.view.redirect

https://gerrit.wikimedia.org/r/166446

Change 166446 merged by jenkins-bot:
Article: Handle double redirects in data for mediawiki.action.view.redirect

https://gerrit.wikimedia.org/r/166446