Page MenuHomePhabricator

Formatting of media player broken inside Listen template
Closed, ResolvedPublic

Description

screenshot of listen template as displayed on en.wiki

Compare media player in...
https://en.wikipedia.org/wiki/Nocturne_in_C-sharp_minor,_Op._posth._%28Chopin%29
...to media player here...
https://commons.wikimedia.org/w/index.php?title=File%3ANocturne_in_D-flat_Major%2C_Op._27%2C_No._2_xo.ogg

Or see screenshot.


Attached:

Listen_screenshot.png (114×336 px, 20 KB)

Details

Reference
bz71601

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:59 AM
bzimport set Reference to bz71601.
bzimport added a subscriber: Unknown Object (MLST).

Looks like this is caused by a bug in jQuery UI that was fixed a while back:
http://bugs.jqueryui.com/ticket/8442

Since we haven't updated jQuery UI in a couple years, I'm guessing there's not much interest in doing so. I'll just backport the bugfix to our current version for now.

Change 164521 had a related patch set uploaded by Kaldari:
Backport of jQuery UI bugfix for ui-helper-clearfix class

https://gerrit.wikimedia.org/r/164521

Is bug 69687 a duplicate of this?

Change 164521 merged by jenkins-bot:
jquery.ui: Collapse border in ui-helper-clearfix

https://gerrit.wikimedia.org/r/164521

  • Bug 48858 has been marked as a duplicate of this bug. ***
  • Bug 69687 has been marked as a duplicate of this bug. ***
kaldari set Security to None.

Change 176620 had a related patch set uploaded (by Kaldari):
Synchronizing Vector jQuery UI styling with core to fix regression

https://gerrit.wikimedia.org/r/176620

Patch-For-Review

Change 176620 merged by jenkins-bot:
Synchronizing Vector jQuery UI styling with core to fix regression

https://gerrit.wikimedia.org/r/176620

Ethanreese claimed this task.
Ethanreese removed a project: TestMe.
Ethanreese added a subscriber: Ethanreese.

Going to the link on wikipedia in the chrome browser on macOS Sierra showed that the alignment error was fixed, and now it is aligned correctly, see the screenshot.

Screen Shot 2016-12-29 at 16.35.38.png (134×316 px, 22 KB)