Page MenuHomePhabricator
Create Task
Maniphest T74659

Call Flow API with DerivativeRequest for server actions
Closed, DeclinedPublic
Actions

Description

There is an apiResponse field in View.php. Some of the contents come from renderApi (shared by the actual API).

However, some are put directly there, which means the data is only available in the template if it's a server rendering. That in turn means the template output differs.

This is a major problem (the architecture is built on the assumption that individual templates behave exactly the same on client and server), and causes bugs like T74655: Shows 'Post a new message to ""' after changing sort order.

Version: unspecified
Severity: normal

Details

Reference
bz72659

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:59 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz72659.
• bzimport added a subscriber: Unknown Object (MLST).
• Mattflaschen-WMF created this task.Oct 29 2014, 3:27 AM
• Mattflaschen-WMF added a comment.Oct 29 2014, 3:28 AM

One approach to solve this is to have View call the actual API with a DerivativeRequest, and pass the API output directly to the template.

However, there are other approaches that still solve this problem.

• Mattflaschen-WMF added a comment.Oct 31 2014, 9:32 PM

(In reply to Matthew Flaschen from comment #1)

One approach to solve this is to have View call the actual API with a
DerivativeRequest, and pass the API output directly to the template.

We're going to try this approach.

EBernhardson triaged this task as High priority.Dec 11 2014, 2:56 AM
EBernhardson added a project: Collaboration-Team-Triage.
EBernhardson set Security to None.

Marking this as high priority as its an important architectural change that needs to happen.

EBernhardson moved this task from Untriaged to Needs team triage on the Collaboration-Team-Triage board.Dec 11 2014, 2:57 AM
• Spage moved this task from Needs team triage to Team discussion on the Collaboration-Team-Triage board.Dec 11 2014, 6:46 PM
Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:25 AM
• Mattflaschen-WMF added a comment.Mar 11 2015, 10:04 PM

This remains somewhat controversial, but consensus seems to be against in the broader MW architecture group.

Some prefer to have backend services/controllers/interactors (somewhat similar to what we have now, but the desired approach is not super well-defined), rather than FauxRequest/DerivativeRequest.

See https://tools.wmflabs.org/meetbot/wikimedia-office/2015/wikimedia-office.2015-03-11-21.00.html and T89889: RFC: Service split along presentation vs data manipulation line.

• Spage updated the task description. (Show Details)Mar 12 2015, 10:40 PM
• DannyH moved this task from Team discussion to Freezer on the Collaboration-Team-Triage board.Aug 21 2015, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2015, 9:51 PM
• Mattflaschen-WMF closed this task as Declined.Mar 18 2016, 12:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits