Page MenuHomePhabricator

flickrripper uses missing config vars tkhorsize & tkvertsize (pylint)
Closed, ResolvedPublic

Description

E:355,44: Module 'pywikibot.config2' has no 'tkhorsize' member (no-member)
E:355,62: Module 'pywikibot.config2' has no 'tkvertsize' member (no-member)


Version: core-(2.0)
Severity: major

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:50 AM
bzimport set Reference to bz73025.
bzimport added a subscriber: Unknown Object (????).

Once done, the following should work in python 2.7

$ python pwb.py shell
>>> from scripts import flickrripper
>>> box = flickrripper.Tkdialog('foo', 'tests/data/MP_sounds.png', 'MP_sounds.png')  # the box appears on this line
>>> box.run()
(u'foobar\n', 'blahblah.png', False)
jayvdb triaged this task as High priority.Dec 7 2014, 2:09 AM
jayvdb added a project: Google-Code-in-2014.
jayvdb set Security to None.
jayvdb removed a subscriber: Unknown Object (????).

I started work on this, please assign this to me please.

Change 179122 had a related patch set uploaded (by Slepice1):
config2:added missing vars and tested them

https://gerrit.wikimedia.org/r/179122

Patch-For-Review

Change 179162 had a related patch set uploaded (by Slepice1):
config2:added missing vars and tested them

https://gerrit.wikimedia.org/r/179162

Patch-For-Review

Change 179167 had a related patch set uploaded (by Slepice1):
config2:added missing vars and tested them

https://gerrit.wikimedia.org/r/179167

Patch-For-Review

Change 179167 abandoned by John Vandenberg:
config2:added missing vars and tested them

Reason:
A commit which should be an amendment of https://gerrit.wikimedia.org/r/#/c/179162/

https://gerrit.wikimedia.org/r/179167

Change 179187 had a related patch set uploaded (by Slepice1):
config2:added missing vars and tested them

https://gerrit.wikimedia.org/r/179187

Patch-For-Review

Change 179187 abandoned by Slepice1:
config2:added missing vars and tested them

https://gerrit.wikimedia.org/r/179187

Change 179162 abandoned by John Vandenberg:
config2:added missing vars and tested them

Reason:
copy of I51545f8f1a3e841bcfc6fe9b1da90f4265770725

https://gerrit.wikimedia.org/r/179162

Change 179122 merged by jenkins-bot:
Tk: added missing config vars and tests

https://gerrit.wikimedia.org/r/179122