pylint is more detailed than flake8, identifying more python stylistic issues.
As we have addressed the issues identified by flakes, it would be good to progress onto fixing pylint issues.
Ideally we add a pre-code-review pylint check to jenkins. It appears to be quite simple to do, using the jenkins plugin violations.
http://www.alexconrad.org/2011/10/jenkins-and-python.html
http://chrigl.de/blogentries/integration-of-pylint-into-jenkins
Version: core-(2.0)
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T74697 Add pylint checking | |||
| Resolved | jayvdb | T75026 titletranslate uses missing date functions (pylint) | |||
| Resolved | None | T75019 welcome -quick fails |
I guess you can start by adding a "pylint" environment in the tox.ini file, then tweak the Jenkins/Zuul configuration file in integration/config.git to create a job that executes pylint and triggers it on the pywikibot repositories.
A tutorial is:
https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Test_your_python
That would be a good first step.
On http://chrigl.de/blogentries/integration-of-pylint-into-jenkins it highlights the use of the Violation plugins which is able to parse pylint output and craft a nice report. The JJB job template for tox does not run it though since it is used to trigger various environment. We might need a dedicated job template.