Page MenuHomePhabricator
Create Task
Maniphest T75409

Flow: magic words for page name in a post render as Topic:UUID but preview as Flow_board_name
Closed, ResolvedPublic
Actions

Description

On a Flow board in the Talk namespace

  1. Add a post containing {{FULLPAGENAME}},{{NAMESPACE}}, and other magic words from https://www.mediawiki.org/wiki/Help:Magic_words#Page_names and #Namespaces
  2. Click Preview
  3. Click submit

Result:

  • During Preview the magic word for the page expands to Talk:<Flow_board_name>
  • But when you submit, the magic word for the page expands to Topic:<UUID>

Expected: I dunno, but this is unexpected.

http://ee-flow.wmflabs.org/wiki/Topic:S62gkgd61sraxk74 has all the magic words.

Version: master
Severity: normal

Details

Reference
bz73409
SubjectRepoBranchLines +/-
Explicitly handle title to preview content againstmediawiki/extensions/Flowmaster+132 -7
Revert "Render posts against the owner page rather than topic"mediawiki/extensions/Flowmaster+3 -12
Render posts against the owner page rather than topicmediawiki/extensions/Flowmaster+12 -3
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:57 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz73409.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Nov 14 2014, 3:07 AM
EBernhardson claimed this task.Dec 11 2014, 2:40 AM
EBernhardson added a project: Collaboration-Team-Triage.
EBernhardson set Security to None.
EBernhardson moved this task from Untriaged to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.
EBernhardson moved this task from Sprint O (ends Jan 27) to Code Review on the Collaboration-Team-Triage board.
gerritbot added a project: Patch-For-Review.Dec 11 2014, 2:41 AM

Change 179056 had a related patch set uploaded (by EBernhardson):
Render posts against the owner page rather than topic

https://gerrit.wikimedia.org/r/179056

Patch-For-Review

• Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:25 AM
• Mattflaschen-WMF added a project: Collaboration-Team-Sprint-P-2015-02-11/q3.Jan 28 2015, 7:22 PM
• Mattflaschen-WMF subscribed.
matthiasmullie moved this task from Sprint P - ends Feb 11 to Code Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 28 2015, 7:28 PM
• Mattflaschen-WMF removed a project: Collaboration-Team-Triage.Jan 28 2015, 7:29 PM
• Mattflaschen-WMF triaged this task as Medium priority.Jan 29 2015, 7:02 PM
matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 30 2015, 1:47 AM
gerritbot subscribed.Jan 30 2015, 1:48 AM

Change 179056 merged by jenkins-bot:
Render posts against the owner page rather than topic

https://gerrit.wikimedia.org/r/179056

EBernhardson mentioned this in rEFLW2a6388a7ec98: Render posts against the owner page rather than topic.Jan 30 2015, 1:48 AM
EBernhardson added a comment.Jan 31 2015, 4:29 AM

I'm thinking now that my patch may have been the wrong solution. The solution was to render topics against the owner page, the implication here is that summaries (T87793) will be adding categories to something. The categories must (well, we could hack it but not preferred) be applied to the same page we are rendering against, which means summaries would categorize the owner page and not the page within NS_TOPIC.

I think we should revert my patch and generate a fake uuid for use in new-topic previews to solve the initial purpose of this patch. Then categorization of summaries can move forward as well.

• DannyH closed this task as Resolved.Feb 3 2015, 11:58 PM
• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.
gerritbot added a comment.Feb 4 2015, 5:58 AM

Change 188253 had a related patch set uploaded (by Mattflaschen):
Revert "Render posts against the owner page rather than topic"

https://gerrit.wikimedia.org/r/188253

Patch-For-Review

• Mattflaschen-WMF reopened this task as Open.Feb 4 2015, 5:58 AM

In addition to the revert (not yet reviewed) (https://gerrit.wikimedia.org/r/#/c/188253/), we also have to do it from the other direction, as Erik said ("generate a fake uuid for use in new-topic previews to solve the initial purpose of this patch").

• DannyH closed this task as Resolved.Feb 4 2015, 11:42 PM
• Mattflaschen-WMF reopened this task as Open.Feb 6 2015, 6:19 AM
• Mattflaschen-WMF moved this task from Done to Code Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.
gerritbot added a comment.Feb 6 2015, 6:23 AM

Change 188253 merged by jenkins-bot:
Revert "Render posts against the owner page rather than topic"

https://gerrit.wikimedia.org/r/188253

• Mattflaschen-WMF mentioned this in rEFLW4f267733e220: Revert "Render posts against the owner page rather than topic".Feb 6 2015, 6:23 AM
• Mattflaschen-WMF added a comment.Feb 6 2015, 7:24 AM

I've now merged the revert. However, I believe the original bug is now valid again, as I said above.

To see this, you can go to http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA and preview:

This is a link to [[Talk:Flow QA]] in a post on {{FULLPAGENAME}}.

in a reply to an existing topic.

It should render with a Topic: page (or a psuedo-one if you preview a new topic), but instead it shows:

This is a link to Talk:Flow QA in a post on Talk:Flow QA.

(if it thinks the page name is Talk:Flow QA, it should render the link in bold, but we could call that out of scope).

• DannyH added a project: Collaboration-Team-Sprint-Q-2015-02-25.Feb 11 2015, 9:26 PM
• DannyH moved this task from Sprint Q - ends Feb 25 to Code Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.
EBernhardson moved this task from Code Review to In Development on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 12 2015, 10:18 PM
EBernhardson moved this task from Code Review to In Development on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 17 2015, 5:05 PM
gerritbot added a comment.Feb 18 2015, 9:39 PM

Change 191474 had a related patch set uploaded (by EBernhardson):
Explicitly handle title to preview content against

https://gerrit.wikimedia.org/r/191474

Patch-For-Review

EBernhardson moved this task from In Development to Code Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 18 2015, 9:39 PM
matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 23 2015, 2:49 PM
gerritbot added a comment.Feb 23 2015, 2:56 PM

Change 191474 merged by jenkins-bot:
Explicitly handle title to preview content against

https://gerrit.wikimedia.org/r/191474

matthiasmullie mentioned this in rEFLW6328b9096efd: Explicitly handle title to preview content against.Feb 23 2015, 2:58 PM
• DannyH closed this task as Resolved.Feb 24 2015, 6:25 PM
Diffusion mentioned this in rMEXT81e3e7ea482a: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:25 AM
Diffusion mentioned this in rMEXTcf21a664bb40: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….
EBernhardson mentioned this in rMEXT1e0d667ae400: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:27 AM
• Mattflaschen-WMF mentioned this in T109373: Flow's usage of the page name magic words is different from wikitext talk pages.Aug 17 2015, 9:40 PM
• Mattflaschen-WMF mentioned this in T132712: Page name magic word behavior is not helpful in Flow discussions.Apr 14 2016, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits